Updated component to version 2.0.5

RELEASE-NOTES.md

@@ -1,6 +1,11 @@
+### Version 2.0.5 - July 20, 2015
+
+- **Checkbox** - Fix issue with `onChange` not firing when space key is used. Checkbox keyboard shortcuts now occur on `keydown` but cancel events correctly on `keyup` [#2676](https://github.com/Semantic-Org/Semantic-UI/issues/2676)
+- **Radio Checkbox** - Fixed regression causing radio checkboxes to all appear selected in chrome due to `:indeterminate` selector [#2505](https://github.com/Semantic-Org/Semantic-UI/issues/2505)
+
 ### Version 2.0.4 - July 17, 2015
 
-- **Checkbox** - Checkbox now focus after click, allowing for tab navigation from current position [#2610](https://github.com/Semantic-Org/Semantic-UI/issues/2610)
+- **Checkbox** - Checkbox now focuses after click, allowing for tab navigation from current position [#2610](https://github.com/Semantic-Org/Semantic-UI/issues/2610)
 - **Checkbox** - Fixed checkbox not using javascript having incorrect colors on focus [#2607](https://github.com/Semantic-Org/Semantic-UI/issues/2607)
 - **Checkbox** - Fixed `space` shortcut causing checkbox to trigger twice
 - **Checkbox** - Updated `colored` theme to add new focus color variables.

checkbox.css

@@ -1,5 +1,5 @@
 /*!
- * # Semantic UI 2.0.4 - Checkbox
+ * # Semantic UI 2.0.5 - Checkbox
  * http://github.com/semantic-org/semantic-ui/
  *
  *
@@ -321,6 +321,12 @@
   background-color: rgba(0, 0, 0, 0.95);
 }
 
+/* Indeterminate */
+.ui.radio.checkbox input:indeterminate ~ .box:after,
+.ui.radio.checkbox input:indeterminate ~ label:after {
+  opacity: 0;
+}
+
 /* Active */
 .ui.radio.checkbox input:checked ~ .box:before,
 .ui.radio.checkbox input:checked ~ label:before {

checkbox.js

@@ -1,5 +1,5 @@
 /*!
- * # Semantic UI 2.0.4 - Checkbox
+ * # Semantic UI 2.0.5 - Checkbox
  * http://github.com/semantic-org/semantic-ui/
  *
  *
@@ -44,6 +44,8 @@ $.fn.checkbox = function(parameters) {
         $label          = $(this).children(selector.label),
         $input          = $(this).children(selector.input),
 
+        shortcutPressed = false,
+
         instance        = $module.data(moduleNamespace),
 
         observer,
@@ -192,11 +194,19 @@ $.fn.checkbox = function(parameters) {
             if(key == keyCode.escape) {
               module.verbose('Escape key pressed blurring field');
               $input.blur();
-              event.preventDefault();
+              shortcutPressed = true;
             }
-            if(!event.ctrlKey && (key == keyCode.enter)) {
-              module.verbose('Enter key pressed, toggling checkbox');
+            else if(!event.ctrlKey && ( key == keyCode.space || key == keyCode.enter) ) {
+              module.verbose('Enter/space key pressed, toggling checkbox');
               module.toggle();
+              shortcutPressed = true;
+            }
+            else {
+              shortcutPressed = false;
+            }
+          },
+          keyup: function(event) {
+            if(shortcutPressed) {
               event.preventDefault();
             }
           }
@@ -455,6 +465,7 @@ $.fn.checkbox = function(parameters) {
             $module
               .on('click'   + eventNamespace, module.event.click)
               .on('keydown' + eventNamespace, selector.input, module.event.keydown)
+              .on('keyup'   + eventNamespace, selector.input, module.event.keyup)
             ;
           }
         },

composer.json

@@ -15,5 +15,5 @@
     "framework"
   ],
   "license": "MIT",
-  "version": "2.0.4"
+  "version": "2.0.5"
 }

index.js

@@ -1,5 +1,5 @@
 /*!
- * # Semantic UI 2.0.4 - Checkbox
+ * # Semantic UI 2.0.5 - Checkbox
  * http://github.com/semantic-org/semantic-ui/
  *
  *
@@ -45,6 +45,8 @@ module.exports = function(parameters) {
         $label          = $(this).children(selector.label),
         $input          = $(this).children(selector.input),
 
+        shortcutPressed = false,
+
         instance        = $module.data(moduleNamespace),
 
         observer,
@@ -193,11 +195,19 @@ module.exports = function(parameters) {
             if(key == keyCode.escape) {
               module.verbose('Escape key pressed blurring field');
               $input.blur();
-              event.preventDefault();
+              shortcutPressed = true;
             }
-            if(!event.ctrlKey && (key == keyCode.enter)) {
-              module.verbose('Enter key pressed, toggling checkbox');
+            else if(!event.ctrlKey && ( key == keyCode.space || key == keyCode.enter) ) {
+              module.verbose('Enter/space key pressed, toggling checkbox');
               module.toggle();
+              shortcutPressed = true;
+            }
+            else {
+              shortcutPressed = false;
+            }
+          },
+          keyup: function(event) {
+            if(shortcutPressed) {
               event.preventDefault();
             }
           }
@@ -456,6 +466,7 @@ module.exports = function(parameters) {
             $module
               .on('click'   + eventNamespace, module.event.click)
               .on('keydown' + eventNamespace, selector.input, module.event.keydown)
+              .on('keyup'   + eventNamespace, selector.input, module.event.keyup)
             ;
           }
         },

package.js

@@ -2,7 +2,7 @@
 Package.describe({
   name    : 'semantic:ui-checkbox',
   summary : 'Semantic UI - Checkbox: Single component release',
-  version : '2.0.4',
+  version : '2.0.5',
   git     : 'git://github.com/Semantic-Org/UI-Checkbox.git',
 });
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "semantic-ui-checkbox",
-  "version": "2.0.4",
+  "version": "2.0.5",
   "title": "Semantic UI - Checkbox",
   "description": "Single component release of checkbox",
   "homepage": "http://www.semantic-ui.com",