Avoid CSS FOUC (#22)

SemanticMediaWiki · Nov 27, 2016 · 492eab0 · 492eab0
1 parent 37262a7
commit 492eab0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/SemanticBreadcrumbLinks.php b/SemanticBreadcrumbLinks.php
@@ -60,14 +60,26 @@ public static function initExtension() {
 		$GLOBALS['wgMessagesDirs']['SemanticBreadcrumbLinks'] = __DIR__ . '/i18n';
 
 		// Register resource files
-		$GLOBALS['wgResourceModules']['ext.semanticbreadcrumblinks'] = array(
+		$GLOBALS['wgResourceModules']['ext.semanticbreadcrumblinks.styles'] = array(
 			'styles'  => 'res/sbl.styles.css',
+			'localBasePath' => __DIR__ ,
+			'remoteExtPath' => 'SemanticBreadcrumbLinks',
+			'position' => 'top',
+			'group'    => 'ext.smw',
+			'targets' => array(
+				'mobile',
+				'desktop'
+			)
+		);
+
+		$GLOBALS['wgResourceModules']['ext.semanticbreadcrumblinks'] = array(
 			'scripts' => 'res/sbl.tooltip.js',
 			'localBasePath' => __DIR__ ,
 			'remoteExtPath' => 'SemanticBreadcrumbLinks',
 			'position' => 'top',
 			'group'    => 'ext.smw',
 			'dependencies'  => array(
+				'ext.semanticbreadcrumblinks.styles',
 				'onoi.qtip'
 			),
 			'targets' => array(

diff --git a/src/PageDisplayOutputModifier.php b/src/PageDisplayOutputModifier.php
@@ -50,8 +50,7 @@ public function setSubpageByNamespace( array $subpageByNamespace ) {
 	 */
 	public function modifyOutput( OutputPage $outputPage ) {
 
-		// #21
-		// $outputPage->addModuleStyles( 'ext.semanticbreadcrumblinks' );
+		$outputPage->addModuleStyles( 'ext.semanticbreadcrumblinks.styles' );
 		$outputPage->addModules( 'ext.semanticbreadcrumblinks' );
 
 		if ( !$this->hideSubpageParentState || !$this->hasSubpageEnabledNamespace( $outputPage->getTitle()->getNamespace() ) ) {