1.0.0 release #21
1.0.0 release #21
Conversation
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| if ( !defined( 'MEDIAWIKI' ) ) die(); | |||
|
|
|||
| define( 'SCQ_VERSION', '0.4.1' ); | |||
| define( 'SCQ_VERSION', '1.0' ); | |||
There was a problem hiding this comment.
I think we have been consistent with the versioning for most of the respo's (== 1.0.0).
Aside from this, after a quick (really quick ~ 30 sec.) look at the code I found that SCQ_QueryResult.php with its method addResult is not being used [0] which suggests dead code (or better a dead class).
So, given the state and quality of the code I'd go with a 0.5 but if you feel comfortable with the quality then go ahead.
[0] https://github.com/SemanticMediaWiki/SemanticCompoundQueries/search?utf8=%E2%9C%93&q=addResult
There was a problem hiding this comment.
I don't agree that one should only go to 1.0 once internal quality reaches a certain threshold. SemVer wise it's about being ready to be used in production, which this extension has been for years.
There was a problem hiding this comment.
Well, I'm aware of the Semver reading and as I pointed out do as you see fit. I don't have a big investment here but of course I'd like to see quality software being released and 1.0 would signal this and in my opinion this repo is not of the quality I'd like to promote.
As far as I can tell this is all that is needed.
Fixes #20
Ping @mwjames