Switch to extension registration mechanism #39
Conversation
|
@mwjames Let's see what happens. I basically imitated what was done for SRF. If something is borked it will most probably be originating from the changes to the "SemanticCompoundQueries.php" file. |
This explains Notice: Use of undefined constant SCQ_VERSION - assumed 'SCQ_VERSION' in /home/travis/build/SemanticMediaWiki/mw/extensions/SemanticCompoundQueries/tests/bootstrap.php on line 11
|
@mwjames It took me a while to add a sensible set of test environments but I guess we are cool now. Since all tests passed a squash and merge should be possible. :) |
|
@mwjames As always, thanks a ton! |
| - env: DB=postgres; MW=REL1_30; SMW=~3.0@dev | ||
| php: 7.2 | ||
| allow_failures: | ||
| - env: DB=mysql; MW=master; SMW=~3.1@dev | ||
|
|
There was a problem hiding this comment.
@mwjames Will it make sense to add PHPUnit to these lines like e.g. in SMT? For a lot of extensions we do not add e.g. SMW=~3.1@dev. I am unsure when to use it and when not. I guess this is to be able to specify a distinct branch and if we do not master of SMW is used? I this case SMW could probably be dropped from the lines
There was a problem hiding this comment.
PHPUnit depends on the required PHP version. MW 1.31 comes with a required PHPUnit version which should work with PHP 7.0 but in some cases MW lacks behind and PHP 7.2/7.3 requires a more recent version of PHPUnit.
So, it all depends, and in some cases you get in discussions with WMF about it [0].
There was a problem hiding this comment.
Indeed, I remember this one. I just mixed in permissible PHPUnits. Still not sure about the SMW part ...
This PR is made in reference to: #38
This PR addresses or contains:
This PR includes:
Fixes: #38