Docker-Compose based CI + Multiple PHP and DB types #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs to be mysql
extend env.template
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #61 +/- ##
=============================================
- Coverage 69.07% 53.71% -15.37%
- Complexity 740 747 +7
=============================================
Files 36 36
Lines 2086 2841 +755
=============================================
+ Hits 1441 1526 +85
- Misses 645 1315 +670 see 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
test 1.39 LTS with mysql 5.7 and 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the github action (ci.yml) to run the (coverage-)tests with different PHP versions, and different Database versions and types. (MySQL 5.7-8, MariaDB, PostgreSQL)
I also changed the runtime from Docker CLI to a Docker-Compose based runtime, which makes it easier to implement features like CI-runs with different Databases.
The Makefile has been optimized (from my point of view) and is now kept similar to the one found in the extention IDProvider.
An .env file(env.template) has been included to make local development / debugging of the make targets easier.