Merge pull request #1665 from SemanticMediaWiki/EntityIdListRelevance…

…DetectionFilter Do not return void method in EntityIdListRelevanceDetectionFilter
SemanticMediaWiki · Jun 17, 2016 · a236f7e · a236f7e
2 parents aeceeea + e21e0d6
commit a236f7e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/SQLStore/QueryDependency/EntityIdListRelevanceDetectionFilter.php b/src/SQLStore/QueryDependency/EntityIdListRelevanceDetectionFilter.php
@@ -136,7 +136,6 @@ private function applyFilterToTableChangeOp( $tableChangeOp, &$affiliateEntityLi
 	}
 
 	private function modifyEntityList( $fieldChangeOp, &$affiliateEntityList, &$combinedChangedEntityList ) {
-
 		$key = '';
 
 		if ( $fieldChangeOp->has( 'key' ) ) {
@@ -148,7 +147,8 @@ private function modifyEntityList( $fieldChangeOp, &$affiliateEntityList, &$comb
 
 		// Exclusion before inclusion
 		if ( isset( $this->propertyExemptionlist[$key]) ) {
-			return $this->unsetEntityList( $fieldChangeOp, $combinedChangedEntityList );
+			$this->unsetEntityList( $fieldChangeOp, $combinedChangedEntityList );
+			return;
 		}
 
 		if ( isset( $this->affiliatePropertyDetectionlist[$key] ) && $fieldChangeOp->has( 's_id' ) ) {