Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDF output of BC dates seems to not comply with XML schema #2233

Open
toniher opened this issue Feb 4, 2017 · 7 comments
Open

RDF output of BC dates seems to not comply with XML schema #2233

toniher opened this issue Feb 4, 2017 · 7 comments
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error RDF

Comments

@toniher
Copy link
Member

toniher commented Feb 4, 2017

Setup and configuration

Tested in sandbox: https://sandbox.semantic-mediawiki.org/wiki/Issue/2233

RDF output: https://sandbox.semantic-mediawiki.org/w/index.php?title=Sp%C3%A9cial:Export_RDF/Issue/2233&syntax=rdf

Issue

Output of XML dates for years in BC era seem not to comply with XML Schema definition:

1.1 Version: https://www.w3.org/TR/xmlschema11-2/#dateTime (previous definition version was different, though: https://www.w3.org/TR/xmlschema-2/#dateTime)

toniher added a commit to toniher/SemanticMediaWiki that referenced this issue Feb 4, 2017
toniher added a commit to toniher/SemanticMediaWiki that referenced this issue Feb 4, 2017
@mwjames
Copy link
Contributor

mwjames commented Feb 5, 2017

I have a problem here that might be related to tests definition: https://travis-ci.org/toniher/SemanticMediaWiki/jobs/198528079 Despite I defined on '#3' skip-on virtuoso, it goes through RDF output test anyway: https://github.com/toniher/SemanticMediaWiki/blob/master/tests/phpunit/Integration/JSONScript/TestCases/p-0451.json
Is there any way to fully skip it for Virtuoso?

Yes there is [0], use the meta field to define:

	"meta": {
		"skip-on": {
			"virtuoso": "Virtuoso 6.1 rdfs / subproperty/subcategory hierarchies are not supported"
		},
		"version": "2",
		"is-incomplete": false,
		"debug": false
	}

[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/Integration/JSONScript/TestCases/q-0802.json

@mwjames
Copy link
Contributor

mwjames commented Feb 5, 2017

Yes there is

... and is now documented [0].

[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/Integration/JSONScript/README.md#skipping-a-test-or-mark-as-incomplete

@toniher
Copy link
Member Author

toniher commented Feb 5, 2017

Thanks, sorry for having deleted the original comment. I discovered this option a few moments later and I wrongly decided to remove it. However, it's very good that you saw it and documented it. Travis turned green and I would try a pull request.

@mwjames
Copy link
Contributor

mwjames commented Feb 5, 2017

Travis turned green and I would try a pull request.

👍

PS: Don't get discouraged when during the week I'm unable to respond, I pushed my "service" hours to the weekend.

@kghbln kghbln changed the title RDF output of BC dates seems not complies with XML schema RDF output of BC dates seems to not comply with XML schema Feb 9, 2017
@kghbln kghbln added the bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error label Feb 9, 2017
@kghbln kghbln added this to the SMW 2.5.0 milestone Feb 9, 2017
@kghbln
Copy link
Member

kghbln commented Mar 7, 2017

@toniher @mwjames Is this something to hurry in 2.5 or hurriable for 2.5?

@toniher
Copy link
Member Author

toniher commented Mar 7, 2017

Hi @kghbln, more development and testing is needed (specially for time offsets and for avoiding breaking previous instances). Since no other people are commenting about this, I would not condition 2.5 release because of this...

@kghbln
Copy link
Member

kghbln commented Mar 7, 2017

@toniher Thanks for the info. So I will move it to 3.0 which does not mean that also a backport to 2.5.x cannot be done at a later stage.

@kghbln kghbln modified the milestones: SMW 3.0, SMW 2.5.0 Mar 7, 2017
@kghbln kghbln modified the milestones: SMW 3.0.0, SMW 3.1.0 Aug 7, 2018
@JeroenDeDauw JeroenDeDauw removed this from the SMW 3.1.0 milestone Aug 13, 2019
@krabina krabina added the RDF label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error RDF
Projects
None yet
Development

No branches or pull requests

5 participants