MW 1.24+ / Hotfix for missing Redirect caused by bug 62856 #420
Conversation
| * @bug 62856 and #212 | ||
| * @since 1.9 | ||
| */ | ||
| public function forceToUseParser() { |
There was a problem hiding this comment.
I can see you really like fluent interfaces :)
This is misplaced here though IMO. If this where a builder, then sure. But parse does not return an instance of a new build thing. It's a method with side effects.
Did you see something like this somewhere else, or recommended somewhere?
There was a problem hiding this comment.
But parse does not return an instance of a new build thing
It is just a switch, so I can do $contentparser->forceToUseParser()->parse() without having to do:
$contentparser->forceToUseParser();
$contentparser->parse();
If it weren't for the bug I wouldn't need this but since the ContentHandler sucks ...
There was a problem hiding this comment.
I think the two liner is better. With the one liner, I find it odd that forceToUseParser changes the state of the $contentparser. It's hiding the side effect.
the ContentHandler sucks
Perhaps, though that is no reason to abuse fluent interfaces here.
There was a problem hiding this comment.
I think the two liner is better.
Perhaps, though that is no reason to abuse fluent interfaces here.
If this makes you happy so be it .. I'm low on battery to argue for or against it.
MW-core has yet to provide a working solution (which it hasn't) but to avoid further delay (due the ContentHandler on redirects) and to fix the problem `forceToUseParser` is added to avoid the `ContentHandler` usage during the Update. SimplePageRedirectRegressionTest is running again on MW 1.24+
|
A new inspection was created. |
MW 1.24+ / Hotfix for missing Redirect caused by bug 62856
|
👍 now master only omits 7 tests which all require |
|
\o/ |
MW-core has yet to provide a working solution (which it hasn't) but to avoid further delay (due the ContentHandler on redirects #212 ) and to fix the problem
forceToUseParseris added to avoid theContentHandlerusage during the Update.SimplePageRedirectRegressionTest is running again on MW 1.24+