-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuntimeException from line 58 of "SingleEntityQueryLookup.php" #4349
Comments
To you happen to have another extension aboard for which you have not updated the dependencies after the upgrade? This topic on mw.o looks pretty similar to me. |
I looked at this code but its not clear to me what is wrong. @mwjames this is one of the things you added recently |
I made sure to download and upload fresh copies of all my extensions before actully trying to update and rebuild. |
Good to know. Thus we can rule out something like this. |
RuntimeException from line 58 of /../wiki/extensions/SemanticMediaWiki/src/SQLStore/Lookup/SingleEntityQueryLookup.php: Expected a ValueDescription instance!
I added the exception for a reason because the code path should never
reach this point but now that it did we need to know what sort of
query would cause the exception case.
`SingleEntityQueryLookup` is only reachable via a `#show` (as noted in
the comment of the class) query and I'd like to know how this `#show`
looks like so that we can design a test case that would fail in a
deterministic way because returning an empty `QueryResult` would be
simple but I would hide the fact that some conditions were injected we
hadn't anticipated.
## How to move forward?
You should run your rebuild with the skip exception argument (see the
doc for details) and isolate the ID (-v outputs the title) that would
cause above condition and look at the wiki text and report back what
#show query is causing the issue.
…On 11/10/19, Karsten Hoffmeyer ***@***.***> wrote:
> I made sure to download and upload fresh copies of all my extensions
> before actully trying to update and rebuild.
Good to know. Thus we can rule out something like this.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#4349 (comment)
|
Unless someone provides instructions on how to replicate the issue, I will close this ticket by next week as observations are not replicable. (It has been 2 month since I responded to the issue!!) |
@MukiA It will be great if you could dig into this
The command:
You will see a number connected to the exception in your shell. With this number you go to special page "SemanticMediaWiki" - "Supplementary functions" - "Entity lookup and disposal" ( |
@kghbln We were able to independently reproduce this on our own system. The most basic Wikitext needed to cause the exception seems to be:
There must be two sets of Other examples:
-- throws exception --
Our System configuration:
|
@kji-mitre Thanks for digging into this and shedding some light on the cause of this issue. Admittedly the cause also reveals why we had not enough fantasy to come up with it. Basically we see a misuse (the docu is indeed not explicit here) of the |
I understand the issue now besides that It remains though that using
No. [0] https://www.semantic-mediawiki.org/wiki/Help:Inline_queries#Parser_function_.23show |
As I mentioned above, the exception was there for a reason which helped us identify some ill defined usage pattern which of course shouldn't raise an exception. Now, that we have retrieved some use cases to test against they remain part of the overall tests in future (for details see the |
Part of the problem was also the documentation provided, which I hopefully have improved now. |
I just looked at the docu and we should think about splitting this mammoth into manageable pieces to be consumable otherwise there is too much text to be confronted with. |
I'm so sorry, I don't use Github and completely forgot about this since I updated to SMW 3.0.2 without any issues and just left it at that. @kghbln Not sure how relevant this is but I ran your suggested command
I read through this thread but didn't really understand what to do to get this sorted out, I am still unable to upgrade SMW without exceptions as I tried again from 3.0.2 to 3.1.5. |
This error just tells you that the location to write the log file to is not writable for SMW. You can specify a location with the |
@kghbln I managed to get it to write to the file, it caught 2 exceptions:
Is it safe to ignore those exceptions and move on? If no, what would you suggest to do? One last question, not sure if this is related to the exceptions but it seems like some text strings are missing after the upgrade: https://i.gyazo.com/edb34db76d1b414c898146c828021198.png |
You are probably using invalid syntax on these two pages. See the conversation starting here: #4349 (comment) I'd fix it. To find pages to the two IDs have a look at the ID lookup docu. The question about the missing strings is completely unrelated. You should have them in your wiki. Check at "MediaWiki:Smw-admin-tab-maintenance" if this page contains some text. This was part of 3.1.5 so I'm not sure why it is missing. |
References
Post to the mailing list.
Setup and configuration
Issue
Stack trace
Produces a stack trace and/or outputs:
Steps to reproduce
The text was updated successfully, but these errors were encountered: