Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context refactoring #842

Closed
davidforgianni opened this issue Feb 21, 2015 · 4 comments
Closed

Context refactoring #842

davidforgianni opened this issue Feb 21, 2015 · 4 comments

Comments

@davidforgianni
Copy link

Contact : @JeroenDeDauw (Tracking request: 37445)

Many places in SMW currently pull in global state to do context dependent tasks. For instance wfLanguage, SMWOutputs::requireResource or $wgUser. We should use proper inversion of control here to inject the dependencies and make sure everything is nicely segregated so we only inject what is actually needed.

Relevant Articles:

@JeroenDeDauw
Copy link
Member

@mwjames seems like you created the bug. An thoughts about the status of this? I do not find the issue very clear with its current phrasing

@mwjames
Copy link
Contributor

mwjames commented Feb 21, 2015

An thoughts about the status of this? I do not find the issue very clear with its current phrasing

By that time we hailed the MediaWiki God to be almighty but soon after it one was shaken from that dream and faced reality by encountering the truth "God is dead".

@mwjames
Copy link
Contributor

mwjames commented Feb 21, 2015

The task would be to remove the RequestContext from the printer interface.

@JeroenDeDauw
Copy link
Member

by encountering the truth "God is dead"

god-is-dead

It seems like we can create two general tracking issues instead:

  • Stop using globals (in non entry point code)
  • Stop using RequestContext / IContextSource / whatever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants