Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ContextSource from ResultPrinter, refs 842 #2748

Merged
merged 1 commit into from Oct 7, 2017
Merged

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Oct 7, 2017

This PR is made in reference to: #2748, cb6c6ad

This PR addresses or contains:

  • Removes the use of ContextSource (RequestContext) from the ResultPrinter instance
  • There is no particular need for the project to carry around a kitchen sink object like the ContextSource which has (and only would) increase dependency on a very specific MediaWiki concept.
  • For now, ResultPrinter provides ResultPrinter::msg as interim's method in case some callers relied upon this method to fetch Message objects

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes: #842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant