Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve spaces in unit labels, refs #1529 #1718

Merged
merged 1 commit into from Sep 1, 2016

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jul 10, 2016

Adds the SMW_DV_NUMV_USPACE flag for preserving spaces in unit labels which up to now has been squashed. For example, sq mi (official notation) is converted to sqmi without the flag.

In order to allow for different spellings a user is expected to maintain a list of permitted notations such as [[Corresponds to::1 km², km ², k m ²]] with the first declaration to mark the "standard" output norm.

To enable this feature smwgDVFeatures requires the SMW_DV_NUMV_USPACE flag (disabled by default to avoid BC as it would require to list all norms explicitly).

@mwjames mwjames added the feature label Jul 10, 2016

@mwjames mwjames added this to the SMW 2.5 milestone Jul 10, 2016

@mwjames mwjames force-pushed the unit-space branch from ca7af7f to e8c0b5e Jul 10, 2016

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jul 10, 2016

Default output

image

Output with spaces

image

Preserve spaces in unit labels, refs 1529
Adds the `SMW_DV_NUMV_USPACE` flag for preserving spaces in unit labels
which up to now has been squashed. For example, `sq mi` (official notation)
is converted to `sqmi` without the flag.

In order to allow for different spellings a user is expected to maintain
a list of permitted notations such as `[[Corresponds to::1 km², km ², k m ²]]`
with the first declaration to mark the "standard" output norm.

To enable this feature `smwgDVFeatures` requires the `SMW_DV_NUMV_USPACE`
flag (disabled by default to avoid BC as it is required to list
all norms explicitly).

@mwjames mwjames force-pushed the unit-space branch from e8c0b5e to e27f892 Sep 1, 2016

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Sep 1, 2016

@kghbln FYI

@mwjames mwjames merged commit fb3459c into master Sep 1, 2016

3 checks passed

Scrutinizer 4 new issues, 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the unit-space branch Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.