Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InTextAnnotationParser to check for possible pipe split, refs #1747 #1753

Merged
merged 1 commit into from Aug 24, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Aug 2, 2016

This PR is made in reference to: #1747

This PR addresses or contains:

  • Changes the behaviour of InTextAnnotationParser in order to recognize that [[Foo|Bar::Foobar]] is a non-value annotation even though it contains a :: marker.

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added the enhancement Alters an existing functionality or behaviour label Aug 2, 2016
@mwjames mwjames added this to the SMW 2.5 milestone Aug 2, 2016
@mwjames
Copy link
Contributor Author

mwjames commented Aug 2, 2016

http://sandbox.semantic-mediawiki.org/wiki/Issue/1747

@SemanticMediaWiki/testers FYI

This PR changes the behaviour of `InTextAnnotationParser` in order
to recognize that `[[Foo|Bar::Foobar]]` is a non-value annotation even
though it contains a `::` marker.
@mwjames mwjames merged commit 6c145ba into master Aug 24, 2016
@mwjames mwjames deleted the issue-1747 branch August 24, 2016 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Alters an existing functionality or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant