New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of MonolingualTextValue in SearchByProperty #1760

Merged
merged 1 commit into from Aug 7, 2016

Conversation

Projects
None yet
1 participant
@mwjames
Contributor

mwjames commented Aug 7, 2016

This PR is made in reference to: # N/A

This PR addresses or contains:

  • Value output (DataValueFormatter::VALUE) will return foo@en instead of the formatted foo (en) allowing SearchByProperty to apply appropriate serialization on behalf of the string value
  • DescriptionFactory now returns a SomeProperty description in case MonolingualTextValue contains a property reference

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added the enhancement label Aug 7, 2016

@mwjames mwjames added this to the SMW 2.5 milestone Aug 7, 2016

@mwjames

This comment has been minimized.

Contributor

mwjames commented Aug 7, 2016

image

@mwjames mwjames merged commit 6a381ea into master Aug 7, 2016

3 checks passed

Scrutinizer 4 new issues, 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the mlt branch Aug 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment