Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyPage avoid unrestricted subproperty query #1927

Merged
merged 1 commit into from Oct 16, 2016
Merged

PropertyPage avoid unrestricted subproperty query #1927

merged 1 commit into from Oct 16, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Oct 16, 2016

This PR is made in reference to: # N/A

This PR addresses or contains:

  • Adds $GLOBALS['smwgSubPropertyListLimit'] (default 25) to avoid running an unlimited SQL query. In case additional subproperties are available that are beyond the limit then a note will appear to inform about the restriction.

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added new feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour enhancement Alters an existing functionality or behaviour labels Oct 16, 2016
@mwjames mwjames added this to the SMW 2.5 milestone Oct 16, 2016
@mwjames
Copy link
Contributor Author

mwjames commented Oct 16, 2016

image

@kghbln FYI

@mwjames mwjames merged commit 8915bcb into master Oct 16, 2016
@mwjames mwjames deleted the limit branch October 16, 2016 21:16
@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Oct 17, 2016
@kghbln kghbln removed the wikidocu missing Code changes (mostly features) what have not yet been documented label Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Alters an existing functionality or behaviour new feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants