Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtraneousLanguage / Extend the CanonicalPropertyAliases members #1943

Merged
merged 1 commit into from
Oct 23, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Oct 23, 2016

This PR is made in reference to: #1848

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added this to the SMW 2.5 milestone Oct 23, 2016
@mwjames
Copy link
Contributor Author

mwjames commented Oct 23, 2016

I wanted to draw attention to a PR that has the potential for a regression

@kghbln FYI; Speaking of regression, I found one while browsing [0]. Properties would appear as redlinks instead of the linking to the property page due to some of them missing the canonical form in the search array (lucky us the sandbox uses FR which allowed to spot this).

image

[0] http://sandbox.semantic-mediawiki.org/wiki/Sp%C3%A9cial:Parcourir/Athens-23_QUERYa9764e9cc227bd29aabe7aebfd41a997

@mwjames mwjames merged commit c90943e into master Oct 23, 2016
@mwjames mwjames deleted the lang-alias branch October 23, 2016 20:02
@kghbln
Copy link
Member

kghbln commented Oct 25, 2016

(lucky us the sandbox uses FR which allowed to spot this)

It was indeed a pretty good idea to do the switch not only to another language than just English as the ultimate fallback language but also to a language like French which is somewhat familiar an providing some linguistic extras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants