Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WikiPageValue to use Sanitizer on caption/label output / Test XSS injection #2000

Merged
merged 1 commit into from Nov 6, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Nov 6, 2016

This PR is made in reference to: # [0]

This PR addresses or contains:

  • Use Sanitizer::removeHTMLtags instead of htmlspecialchars_decode

This PR includes:

  • Tests (unit/integration)
  • CI build passed

[0] http://wikimedia.7.x6.nabble.com/Modify-table-header-in-quot-further-results-quot-td5068597.html

…ection

Use Sanitizer::removeHTMLtags instead of htmlspecialchars_decode
@mwjames mwjames merged commit b84c84c into master Nov 6, 2016
@mwjames mwjames deleted the sani branch November 6, 2016 23:53
@mwjames
Copy link
Contributor Author

mwjames commented Nov 6, 2016

@kghbln FYI

[0] query headers should display with the same output now in Special:Ask as compared with embedded queries.

[0] http://sandbox.semantic-mediawiki.org/wiki/Modify_table_head

@kghbln
Copy link
Member

kghbln commented Nov 7, 2016

query headers should display with the same output now in Special:Ask as compared with embedded queries.

@stefahn FYI

@mwjames Great, this works perfect now! Many thanks! I probably should have come up with this earlier: Will it be possible to allow just wiki links like [[page|label]] and [[page]] for intro and outro?

@stefahn
Copy link

stefahn commented Nov 7, 2016

@kghbln Thanks for informing me on this!

@mwjames Great work! Thanks a lot! Waiting for the next release in which this improvement will be included.

@mwjames
Copy link
Contributor Author

mwjames commented Nov 12, 2016

Will it be possible to allow just wiki links like [[page|label]] and [[page]] for intro and outro?

It's a different function but #2007 should help providing the expected results.

@kghbln
Copy link
Member

kghbln commented Nov 12, 2016

It's a different function but #2007 should help providing the expected results.

WOW, this is great. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants