Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter interpretation of the "UniquenessConstraint", refs 1463 #2113

Merged
merged 1 commit into from Dec 17, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Dec 17, 2016

This PR is made in reference to: #1463

This PR addresses or contains:

  • Checks that no competing values on the same subject/property are declared for when the property is specified as [[Has uniqueness constraint::true]]

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added this to the SMW 2.5 milestone Dec 17, 2016
@mwjames
Copy link
Contributor Author

mwjames commented Dec 17, 2016

For example denoting [[NDL ID::00629192]] and [[NDL ID::00629193]] on the same subject will no longer be permitted. The first assigned value is attributed to be "valid" (given that no other subject has made a uniqueness claim for this property value) and any other competing value to the same property is declared as invalid.

https://sandbox.semantic-mediawiki.org/wiki/Issue/2113

@mwjames mwjames merged commit b9e2cb0 into master Dec 17, 2016
@mwjames mwjames deleted the unique branch December 17, 2016 14:16
@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Dec 18, 2016
@kghbln
Copy link
Member

kghbln commented Dec 19, 2016

Now documented.

@kghbln kghbln removed the wikidocu missing Code changes (mostly features) what have not yet been documented label Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants