Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UsageStatisticsListLookup to add TOTALPROPS #2137

Merged
merged 1 commit into from Dec 31, 2016
Merged

UsageStatisticsListLookup to add TOTALPROPS #2137

merged 1 commit into from Dec 31, 2016

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Dec 31, 2016 •
edited

This PR is made in reference to: #

This PR addresses or contains:

  • TotalPropertiesCount is not to count property subobjects
  • UsedPropertiesCount to use an INNER JOIN to match only valid properties

image

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added the enhancement Alters an existing functionality or behaviour label Dec 31, 2016
@mwjames mwjames added this to the SMW 2.5 milestone Dec 31, 2016
@mwjames mwjames merged commit 1b801ce into master Dec 31, 2016
@mwjames mwjames deleted the usage-stats branch December 31, 2016 22:40
@mwjames
Copy link
Contributor Author

mwjames commented Jan 1, 2017

@kghbln FYI

@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Alters an existing functionality or behaviour wikidocu missing Code changes (mostly features) what have not yet been documented
Projects
None yet
Milestone
SMW 2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwjames @kghbln