Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Property/Concept NS to $wgContentNamespaces/$wgNamespacesToBeSearchedDefault #2243

Merged
merged 1 commit into from Feb 12, 2017

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Feb 11, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • $wgContentNamespaces to allow custom namespaces to be acknowledged as containing useful content
  • $wgNamespacesToBeSearchedDefault to indicate which namespaces are enabled for searching by default

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added this to the SMW 2.5.0 milestone Feb 11, 2017
@mwjames
Copy link
Contributor Author

mwjames commented Feb 12, 2017

@kghbln FYI

@mwjames mwjames merged commit 1c6ad41 into master Feb 12, 2017
@mwjames mwjames deleted the cnt-ns branch February 12, 2017 14:37
@kghbln
Copy link
Member

kghbln commented Feb 15, 2017

Documented on smw.o.

@mwjames At least the setting about changing the content namespaces is debatable. I personally am indifferent about "Property" but I see "Concept" as a dynamic category which I do not think is content in every situation. I guess it will be possible to override the setting as I documented it. Also we should mention in the release notes that "updateArticleCount.php" should be run after an upgrade from an earlier version by referring to the docu I added. Thus people are also deliberately invited to think about this and act at their convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants