Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParserAfterTidy avoid Parser::lock (Parser state cleared while parsing) #2294

Merged
merged 1 commit into from Mar 4, 2017

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Mar 4, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • Edge case for when a purge request on a redirect remained active during a UpdateJob

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames
Copy link
Contributor Author

mwjames commented Mar 4, 2017

[de353854b54a571ce123aac9] [no req]   MWException from line 6404 of ...\includes\parser\Parser.php: Parser state cleared while parsing. Did you call Parser::parse recursively?
Backtrace:
#0 ...\includes\parser\Parser.php(414): Parser->lock()
#1 ...\includes\content\WikitextContent.php(331): Parser->parse(boolean, Title, ParserOptions, boolean, boolean, integer)
#2 ...\includes\content\AbstractContent.php(497): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#3 ...\SemanticMediaWiki\includes\ContentParser.php(184): AbstractContent->getParserOutput(Title, integer, NULL, boolean)
#4 ...\SemanticMediaWiki\includes\ContentParser.php(144): SMW\ContentParser->fetchFromContent()
#5 ...\SemanticMediaWiki\src\MediaWiki\Jobs\UpdateJob.php(128): SMW\ContentParser->parse()
#6 ...\SemanticMediaWiki\src\MediaWiki\Jobs\UpdateJob.php(112): SMW\MediaWiki\Jobs\UpdateJob->needToParsePageContentBeforeUpdate()
#7 ...\SemanticMediaWiki\src\MediaWiki\Jobs\UpdateJob.php(80): SMW\MediaWiki\Jobs\UpdateJob->doPrepareForUpdate()
#8 ...\SemanticMediaWiki\src\MediaWiki\Jobs\UpdateJob.php(61): SMW\MediaWiki\Jobs\UpdateJob->doUpdate()
#9 ...\SemanticMediaWiki\includes\storage\SQLStore\SMW_SQLStore3_Writers.php(965): SMW\MediaWiki\Jobs\UpdateJob->run()
#10 [internal function]: SMWSQLStore3Writers->{closure}()
#11 ...\SemanticMediaWiki\src\DeferredCallableUpdate.php(219): call_user_func(Closure)
#12 ...\SemanticMediaWiki\src\DeferredCallableUpdate.php(245): SMW\DeferredCallableUpdate->doUpdate()
#13 ...\SemanticMediaWiki\includes\storage\SQLStore\SMW_SQLStore3_Writers.php(969): SMW\DeferredCallableUpdate->pushUpdate()
#14 ...\SemanticMediaWiki\includes\storage\SQLStore\SMW_SQLStore3_Writers.php(688): SMWSQLStore3Writers->addToDeferredUpdate(Title, Title, integer)
#15 ...\SemanticMediaWiki\includes\storage\SQLStore\SMW_SQLStore3.php(282): SMWSQLStore3Writers->changeTitle(Title, Title, integer, integer)
#16 ...\SemanticMediaWiki\includes\StoreUpdater.php(277): SMWSQLStore3->changeTitle(Title, Title, integer, integer)
#17 ...\SemanticMediaWiki\includes\StoreUpdater.php(247): SMW\StoreUpdater->doUpdateUnknownRedirectTarget(SMW\SemanticData, SMW\DIWikiPage)
#18 ...\SemanticMediaWiki\includes\StoreUpdater.php(213): SMW\StoreUpdater->checkOnRequiredRedirectUpdate(SMW\SemanticData)
#19 ...\SemanticMediaWiki\includes\StoreUpdater.php(142): SMW\StoreUpdater->doRealUpdate()
#20 ...\SemanticMediaWiki\includes\StoreUpdater.php(96): SMW\StoreUpdater->doPerformUpdate()
#21 ...\SemanticMediaWiki\includes\ParserData.php(318): SMW\StoreUpdater->doUpdate()
#22 [internal function]: SMW\ParserData->SMW\{closure}()
#23 ...\SemanticMediaWiki\src\DeferredCallableUpdate.php(219): call_user_func(Closure)
#24 ...\SemanticMediaWiki\src\DeferredCallableUpdate.php(245): SMW\DeferredCallableUpdate->doUpdate()
#25 ...\SemanticMediaWiki\includes\ParserData.php(330): SMW\DeferredCallableUpdate->pushUpdate()
#26 ...\SemanticMediaWiki\src\MediaWiki\Hooks\ParserAfterTidy.php(170): SMW\ParserData->updateStore(boolean)
#27 ...\SemanticMediaWiki\src\MediaWiki\Hooks\ParserAfterTidy.php(88): SMW\MediaWiki\Hooks\ParserAfterTidy->checkForRequestedUpdateByPagePurge(SMW\ParserData)
#28 ...\SemanticMediaWiki\src\MediaWiki\Hooks\ParserAfterTidy.php(49): SMW\MediaWiki\Hooks\ParserAfterTidy->performUpdate()
#29 ...\SemanticMediaWiki\src\MediaWiki\Hooks\HookRegistry.php(145): SMW\MediaWiki\Hooks\ParserAfterTidy->process()
#30 [internal function]: SMW\MediaWiki\Hooks\HookRegistry->SMW\MediaWiki\Hooks\{closure}(Parser, string)
#31 ...\includes\Hooks.php(195): call_user_func_array(Closure, array)
#32 ...\includes\parser\Parser.php(1372): Hooks::run(string, array)
#33 ...\includes\parser\Parser.php(444): Parser->internalParseHalfParsed(string, boolean, boolean)
#34 ...\includes\content\WikitextContent.php(331): Parser->parse(boolean, Title, ParserOptions, boolean, boolean, integer)
#35 ...\includes\content\AbstractContent.php(497): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#36 ...\SemanticMediaWiki\includes\ContentParser.php(184): AbstractContent->getParserOutput(Title, integer, NULL, boolean)
#37 ...\SemanticMediaWiki\includes\ContentParser.php(144): SMW\ContentParser->fetchFromContent()
#38 ...\SemanticMediaWiki\src\MediaWiki\Jobs\UpdateJob.php(128): SMW\ContentParser->parse()
#39 ...\SemanticMediaWiki\src\MediaWiki\Jobs\UpdateJob.php(112): SMW\MediaWiki\Jobs\UpdateJob->needToParsePageContentBeforeUpdate()
#40 ...\SemanticMediaWiki\src\MediaWiki\Jobs\UpdateJob.php(80): SMW\MediaWiki\Jobs\UpdateJob->doPrepareForUpdate()
#41 ...\SemanticMediaWiki\src\MediaWiki\Jobs\UpdateJob.php(61): SMW\MediaWiki\Jobs\UpdateJob->doUpdate()
#42 ...\SemanticMediaWiki\src\Maintenance\DistinctEntityDataRebuilder.php(162): SMW\MediaWiki\Jobs\UpdateJob->run()
#43 ...\SemanticMediaWiki\src\Maintenance\DistinctEntityDataRebuilder.php(142): SMW\Maintenance\DistinctEntityDataRebuilder->doExecuteUpdateJobFor(Title)
#44 ...\SemanticMediaWiki\src\Maintenance\DataRebuilder.php(194): SMW\Maintenance\DistinctEntityDataRebuilder->doRebuild()
#45 ...\SemanticMediaWiki\src\Maintenance\DataRebuilder.php(165): SMW\Maintenance\DataRebuilder->doRebuildDistinctEntities()
#46 ...\SemanticMediaWiki\maintenance\rebuildData.php(150): SMW\Maintenance\DataRebuilder->rebuild()
#47 ...\maintenance\doMaintenance.php(103): SMW\Maintenance\RebuildData->execute()
#48 ...\SemanticMediaWiki\maintenance\rebuildData.php(198): require_once(string)
#49 {main}

@mwjames mwjames merged commit 0514f55 into master Mar 4, 2017
@mwjames mwjames deleted the parse-lock branch March 4, 2017 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant