Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllowsListValue #2295

Merged
merged 1 commit into from Mar 4, 2017
Merged

Add AllowsListValue #2295

merged 1 commit into from Mar 4, 2017

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Mar 4, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • Maintain a list of allowed list via MediaWiki:Smw allows list ... using [[Allows value list::...]] instead of individual [[Allows value:: ...]] annotations
  • Expects the form of a hierarchy list which in its raw form (without the levels) isn't used directly by SMW but other processes may want to to create multilevel dropdown input forms using the hierarchy given in the MediaWiki:Smw allows list ... page
  • [[Allows value list::Foo]] is linked to MediaWiki:Smw allows list Foo
  • Each valid list item in MediaWiki:Smw allows list ... is expected to start with * (e.g * Bar or ** Foobar)
  • Mixing of [[Allows value:: ...]] and [[Allows value list::...]] within a property specification is allowed

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added the new feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour label Mar 4, 2017
@mwjames mwjames added this to the SMW 2.5.0 milestone Mar 4, 2017
@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Mar 4, 2017
@mwjames mwjames merged commit 0a91e1f into master Mar 4, 2017
@mwjames mwjames deleted the list branch March 4, 2017 12:05
@kghbln kghbln removed the wikidocu missing Code changes (mostly features) what have not yet been documented label Mar 4, 2017
@mwjames
Copy link
Contributor Author

mwjames commented Mar 5, 2017

A different perspective on using Allows value list is that changes to a reference list is not coupled by updating depending property values. For a property that has a large value pool that requires validation, an updated list will no automatically force a surge in update jobs due to a changed content list.

Whether this a positive or negative outcome is (was) not part of this PR and if such dispatch job is required, a new discussion should be opened for elaborating on related use cases.

PS: Of course, any new value assignment to a property will use the updated list.

mwjames added a commit that referenced this pull request Mar 11, 2017
@kghbln kghbln mentioned this pull request Mar 11, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants