Add HtmlTable, refs 2387 #2409
Merged
Add HtmlTable, refs 2387 #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return string | ||
| */ | ||
| public static function table( $html = '', array $attributes = array() ) { |
There was a problem hiding this comment.
Well, its better than having span and div's being sprinkled all over the code. Nothing wrong on using statics where an instance isn't required.
There was a problem hiding this comment.
Like this you cannot provide an alternative implementation though
There was a problem hiding this comment.
Clearly one of those cases where using static is not a total disaster, but still. Esp since you delegate to MediaWiki's Html... I'd be using an instance
mwjames
added a commit
that referenced
this pull request
Apr 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made in reference to: #2387
This PR addresses or contains:
This PR includes: