Support the wpUploadDescription in ext.smw.suggester.textInput.js
#2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
* Opens "Files changed"
* Code appears
* Whaaaaaat!?!!?????
* Oh this is a copy of what James suggested
* Leaves an unhelpful comment without reviewing the code
Maybe I'm missing the point here but what exactly is this suppose to
mean? Is the comment helpful to the volunteer who made the PR?
…On 10/10/17, Jeroen De Dauw ***@***.***> wrote:
* Opens "Files changed"
* Code appears
* Whaaaaaat!?!!?????
* Oh this is a copy of what James suggested
* Leaves an unhelpful comment without reviewing the code
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#2756 (comment)
|
|
I guess this is the description of what happened chronologically. He saw the great code change and was surprised that I could have come up with this. When he saw my comment and decided to leave this pull to you. |
|
Anyway, if you have confirmed this to be working don't wait on me,
feel free to merge!
…On 10/10/17, Karsten Hoffmeyer ***@***.***> wrote:
I guess this is the description of what happened chronologically. He saw the
great code change and was surprised that I could have come up with this.
When he saw my comment and decided to leave this pull to you.
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#2756 (comment)
|
A field test reveals that it is working. Cool! |
The comment already answers that for you ;) Though perhaps now it is wrong, since it invoked a bunny, which is a win in my book.
I'm sure you could if you put your time into it, it's just not what I expected |
mwjames
changed the title
wpUploadDescription in ext.smw.suggester.textInput.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made in reference to: #2726
This PR addresses or contains:
This PR includes: