Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError in DuplicateEntitiesDisposer, refs 2932 #3215

Merged
merged 1 commit into from Jul 15, 2018
Merged

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Jul 15, 2018

This PR is made in reference to: #2932

This PR addresses or contains:

  • Check whether an object is iterable or not

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Error

TypeError from line 68 of ...\extensions\SemanticMediaWiki\src\Maintenance\DuplicateEntitiesDisposer.php:
Argument 1 passed to SMW\Maintenance\DuplicateEntitiesDisposer::doDispose() must be of the type array, object given, called in ...\extensions\SemanticMediaWiki\src\Maintenance\DuplicateEntitiesDisposer.php on line 60

@mwjames mwjames merged commit aacf789 into master Jul 15, 2018
@mwjames mwjames deleted the duplicate branch July 15, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant