Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ErrorLookup to scan subobjects, cache lookup, refs 3968 #3989

Merged
merged 1 commit into from May 5, 2019

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented May 5, 2019

This PR is made in reference to: #3968, #3987

This PR addresses or contains:

  • Extends ErrorLookup to also scan on subjects when smwgCheckForConstraintErrors is set to SMW_CONSTRAINT_ERR_CHECK_ALL (default setting)
  • Adds caching to ConstraintErrorIndicatorProvider so that repeated page views will avoid active DB reads
  • Default lookup limit is set to 20

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Example

image

@mwjames mwjames merged commit 2c7ab4e into master May 5, 2019
@mwjames mwjames deleted the error-lookup branch May 5, 2019 21:07
@kghbln kghbln added wikidocu missing Code changes (mostly features) what have not yet been documented enhancement Alters an existing functionality or behaviour releasenotes labels Sep 22, 2019
@kghbln kghbln added this to the SMW 3.1.0 milestone Sep 22, 2019
@kghbln
Copy link
Member

kghbln commented Sep 22, 2019

@kghbln kghbln removed releasenotes wikidocu missing Code changes (mostly features) what have not yet been documented labels Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Alters an existing functionality or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants