Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Browse use structured array instead of hash #4452

Merged
merged 1 commit into from Jan 25, 2020
Merged

Special:Browse use structured array instead of hash #4452

merged 1 commit into from Jan 25, 2020

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Jan 25, 2020

This PR is made in reference to: https://twitter.com/48pedia/status/1220697188948303873

This PR addresses or contains:

  • Uses a structured array instead of a simple hash to make sure the API request uses the correct key hereby fixes an edge case (see link) where the subobject name contains # as part of the name (not as part of the identifier)

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@kghbln kghbln added the enhancement Alters an existing functionality or behaviour label Jan 25, 2020
@kghbln kghbln added this to the SMW 3.2.0 milestone Jan 25, 2020
@mwjames
Copy link
Contributor Author

mwjames commented Jan 25, 2020

https://sandbox.semantic-mediawiki.org/wiki/Issue/4452

@kghbln FYI, Browsing of either Issue/4452##Foo or Issue/4452##好きなんだ is the issue here.

Semantic MediaWiki Has subobjectの「#好きなんだ」どうすればいいのか

あの質問の答えは「新たにリリースを発表することを待つべきです。」

@mwjames mwjames merged commit 51a804c into master Jan 25, 2020
@kghbln kghbln deleted the browse branch January 27, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Alters an existing functionality or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants