Don't call WebRequest::getLimitOffset in 1.35 #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See T245779
See T245779
See T245779
See T245779
| return $request->getLimitOffsetForUser( $this->getUser() ); | ||
| } else { | ||
| return $request->getLimitOffset(); | ||
| } |
There was a problem hiding this comment.
You can write this without the else part:
if ( method_exists( $request, 'getLimitOffsetForUser' ) ) {
// MW 1.35+
return $request->getLimitOffsetForUser( $this->getUser() );
}
return $request->getLimitOffset();There was a problem hiding this comment.
True, but I was using the same code block that I was using elsewhere where it wasn't returning, but rather setting a variable, so I kept the else block
There was a problem hiding this comment.
That is part of the reason why using a guard clause (the form in my variation) is nice.
There was a problem hiding this comment.
JeroenDeDauw
approved these changes
Feb 21, 2020
|
@DannyS712 Thanks a lot for the pull! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://phabricator.wikimedia.org/T245779