Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove smwgContLang #4618

Merged
merged 1 commit into from Mar 1, 2020
Merged

Remove smwgContLang #4618

merged 1 commit into from Mar 1, 2020

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Mar 1, 2020

This PR is made in reference to: #1848, #1896, #1941

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames merged commit b4e5171 into master Mar 1, 2020
@mwjames mwjames deleted the rem-smwgcontlang branch March 1, 2020 14:14
@mwjames
Copy link
Contributor Author

mwjames commented Mar 1, 2020

@kghbln Could be that PF is relying on that but honestly that isn't any of my concern since SMW isn't using it since at least 2.5 and it should have never been a $GLOBALS in the first place. Anyway, out of compliance I added smwfContLang() which they can rely upon if the necessity arises.

With this PR all settings parameters in the Settings object are stateless and can now be easily serialized.

@kghbln
Copy link
Member

kghbln commented Mar 1, 2020

How can I find out? When I do a code search I get no results for any extensions but SMW. In the end I would like to create a somewhat decent error report.

@mwjames
Copy link
Contributor Author

mwjames commented Mar 1, 2020

How can I find out? When I do a code search I get n

You searched for the wrong term, using smwgContLang instead of smwfContLang because smwfContLang() is a function I introduced with this PR.

https://codesearch.wmflabs.org/extensions/?q=smwgContLang&i=nope&files=&repos=

@kghbln
Copy link
Member

kghbln commented Mar 1, 2020

You searched for the wrong term, using smwgContLang instead of smwfContLang because smwfContLang() is a function I introduced with this PR.

Thanks for the info. Three extensions affected and information provided:

@kghbln kghbln added this to the SMW 3.2.0 milestone Mar 1, 2020
@mwjames
Copy link
Contributor Author

mwjames commented Apr 11, 2020

@kghbln FYI https://phabricator.wikimedia.org/T249172 is the consequence of this change because $smwgContLang no longer exists as explained above.

	$datatypeLabels = $smwgContLang->getDatatypeLabels();

@kghbln
Copy link
Member

kghbln commented Apr 11, 2020

Thanks for the note. I cross-referenced the two issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants