Fix Link to "Special:Browse" no longer shown for Vector

[StarHeartHunt]

No description provided.

[kghbln]

@JeroenDeDauw Could you have a peep...

[JeroenDeDauw]

Please drop the since tags, they are incorrect

[StarHeartHunt]

Dropped in the latest commit

[JeroenDeDauw]

@StarHeartHunt did you test this? Against which MW version(s)?

It is a bit scary to merge this new code without any automated tests for it.

[StarHeartHunt]

@StarHeartHunt did you test this? Against which MW version(s)?

It is a bit scary to merge this new code without any automated tests for it.

I have tested this on 1.35 & 1.31.10.I checked the behavior and found nothing wrong.Since I couldn't get the PHPUnit tests to run locally, I gave up to write a test script.☹️

[JeroenDeDauw]

Uhhhhh this broke the CI

There was 1 failure:

1. SMW\Tests\MediaWiki\HooksTest::testCheckOnMissingHandlers

Missing a SidebarBeforeOutput test!

Failed asserting that an array has the key 'SidebarBeforeOutput'.

/home/travis/build/SemanticMediaWiki/mw/extensions/SemanticMediaWiki/tests/phpunit/Unit/MediaWiki/HooksTest.php:257

/home/travis/build/SemanticMediaWiki/mw/maintenance/doMaintenance.php:94

(from https://travis-ci.org/github/SemanticMediaWiki/SemanticMediaWiki/jobs/735989762)

@StarHeartHunt you could write it without having the tests run locally. Just push to a branch here on GitHub and see if it works on Travis.

[kghbln]

I guess this is somehow breaking for SMW 3.2.x and MW 1.31.x in conjunction with the Medik skin 3.x, i.e. I either get the MediaWiki tools in the drowdown menu OR the link to Special:Browse. However since MW 1.31.x is on the way out in two months we should no longer worry. To get at least the MediaWiki stuff working again one has to set:

$smwgBrowseFeatures = ( $smwgBrowseFeatures & ~SMW_BROWSE_TLINK );

On MW 1.35.x with SWM 3.2.x and Medik 3.2.x everything is fluff. See sandbox.s-mw.o. Same for MW 1.31.x with SWM 3.1.x and Medik 3.2.x