Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid registering connection providers too early #5021

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Avoid registering connection providers too early #5021

merged 1 commit into from
Jul 12, 2021

Conversation

Abijeet
Copy link
Contributor

@Abijeet Abijeet commented Jul 12, 2021

Causes: Premature access to service container
Caused by: https://gerrit.wikimedia.org/r/651539

Drawbacks with the change: Cannot load SMW extensions before
calling enableSemantics. See: #4195

Causes: Premature access to service container
Caused by: https://gerrit.wikimedia.org/r/651539

Drawbacks with the change: Cannot load SMW extensions before
calling enableSemantics. See: #4195
@JeroenDeDauw JeroenDeDauw merged commit 015e9c4 into SemanticMediaWiki:master Jul 12, 2021
@Abijeet Abijeet deleted the fix-service-container branch July 13, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants