MW 1.23 / Fatal error: Cannot access protected property ImageGallery::$mParser in Gallery.php on line 328

[mwjames]

Fatal error: Cannot access protected property ImageGallery::$mParser in ...\extensions\SemanticResultFormats\formats\gallery\Gallery.php on line 328

Call Stack:
    0.0028     168800   1. {main}() ...\maintenance\runJobs.php:0
    0.0124     382416   2. require_once('...\maintenance\doMaintenance.php') C:\xampp\htdocs\mw\maintenance\runJobs.php:271
    0.4075    6684840   3. RunJobs->execute() ...\maintenance\doMaintenance.php:107
  427.3063   26540192   4. SMW\UpdateJob->run() ...\maintenance\runJobs.php:106
  427.3064   26539480   5. SMW\UpdateJob->runUpdate() ...\extensions\SemanticMediaWiki\includes\jobs\UpdateJob.php:52
  427.3095   26540192   6. SMW\UpdateJob->runContentParser() ...\extensions\SemanticMediaWiki\includes\jobs\UpdateJob.php:79
  427.3104   26549176   7. SMW\ContentParser->parse() ...\extensions\SemanticMediaWiki\includes\jobs\UpdateJob.php:102
  427.3105   26549208   8. SMW\ContentParser->fetchFromContent() ...\extensions\SemanticMediaWiki\includes\ContentParser.php:112
  427.3204   26554096   9. WikitextContent->getParserOutput() ...\extensions\SemanticMediaWiki\includes\ContentParser.php:155
  427.3219   26563416  10. Parser->parse() ...\includes\content\WikitextContent.php:319
  427.3230   26558952  11. Parser->internalParse() ...\includes\parser\Parser.php:395
  427.3231   26559608  12. Parser->replaceVariables() ...\includes\parser\Parser.php:1212
  427.3330   26560368  13. PPFrame_DOM->expand() ...\includes\parser\Parser.php:3147
  427.3349   26564784  14. Parser->braceSubstitution() ...\includes\parser\Preprocessor_DOM.php:1113
  427.3361   26566816  15. Parser->callParserFunction() ...\includes\parser\Parser.php:3330
  427.3418   26567864  16. call_user_func_array() ...\includes\parser\Parser.php:3613
  427.3419   26568440  17. SMW\Setup->SMW\{closure}() ...\includes\parser\Parser.php:3613
  427.3441   26571000  18. SMW\AskParserFunction->parse() ...\extensions\SemanticMediaWiki\includes\Setup.php:510
  427.3442   26571456  19. SMW\AskParserFunction->runQueryProcessor() ...\extensions\SemanticMediaWiki\includes\parserhooks\AskParserFunction.php:84
  427.4295   26447808  20. SMWQueryProcessor::getResultFromQuery() ...\extensions\SemanticMedaWiki\includes\parserhooks\AskParserFunction.php:130
  427.4393   26447880  21. SMW\ResultPrinter->getResult() ...\extensions\SemanticMediaWiki\includes\query\SMW_QueryProcessor.php:505
  427.4403   26449464  22. SRF\Gallery->buildResult() ...\extensions\SemanticMediaWiki\includes\queryprinters\ResultPrinter.php:209
  427.4403   26449464  23. SRF\Gallery->getResultText() ...\extensions\SemanticResultFormats\formats\gallery\Gallery.php:67
  427.4413   26458208  24. SRF\Gallery->addImagePages() ...\extensions\SemanticResultFormats\formats\gallery\Gallery.php:160
  427.4509   26464448  25. SRF\Gallery->addImageToGallery() ...\extensions\SemanticResultFormats\formats\gallery\Gallery.php:298

[mwjames]

Someone changed the visibility in MW/1.23 ([0]) which now breaks the SRF/Gallery format.

[0] wikimedia/mediawiki@fd07e5e#diff-a77c19c1bdef2fc13814750eb4ae2f84

[JeroenDeDauw]

@siebrand Any suggestion on how to fix this?

[siebrand]

Make public and backport?

[JeroenDeDauw]

@hexmode From our side this is a bug that will be problematic if it gets into the 1.23 release

[mwjames]

Make public and backport?

@hexmode To keep compatibility, ImageGallery::$mParser should be made public again otherwise an in-release change (such as in MW 1.23 without deprecation notice) causes breakage of existing and established functionality.

[hexmode]

See https://gerrit.wikimedia.org/r/#/c/131265/

It would be really good if you guys could get +2 over there.

[JeroenDeDauw]

See https://gerrit.wikimedia.org/r/#/c/131265/

Thanks for taking care of that!

It would be really good if you guys could get +2 over there.

Right. That is not happening unless some serious political changes occurred.