Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTables: Inline limit set to 750 #20

Closed
mwjames opened this issue Mar 13, 2014 · 6 comments
Closed

DataTables: Inline limit set to 750 #20

mwjames opened this issue Mar 13, 2014 · 6 comments

Comments

@mwjames
Copy link
Contributor

mwjames commented Mar 13, 2014

On the mailing-list the following appeared as question "s there a hard 750 on limit parameter for the amount of rows you can request in results format datatables?"

I don't remember why the value was set to 750 but you could change it to something like:

inlineLimit: smw.settings.get( 'smwgQMaxLimit' )
@JeroenDeDauw
Copy link
Member

I happen to know what the context of this is since I saw the thread of the mailing list. That is however totally not obvious. All this ticket states is "the limit is 750" and "I don't know why it's 750". It does not specify what the issue is or the desired change. You could link the mailing list post, though I'm, dubious of posting this here to begin with, if it is not elaborated on in some way. Why did you post here?

@mwjames
Copy link
Contributor Author

mwjames commented Mar 14, 2014

Why did you post here?

If in future the DataTables format sees an update, above solution should be use instead.

@kghbln kghbln added this to the 1.9.0.2 milestone Mar 27, 2014
@mwjames mwjames removed this from the 1.9.1 milestone Apr 22, 2014
@kghbln
Copy link
Member

kghbln commented May 15, 2015

I think making this format listen to $smwgQMaxLimit will be a nice enhancement

@kghbln
Copy link
Member

kghbln commented Jul 2, 2015

@mwjames Is there any objection to changing this line with the patch provided in you initial #20 (comment)?

@mwjames
Copy link
Contributor Author

mwjames commented Jul 7, 2015

Is there any objection to changing this line with the patch provided in you initial

No objections.

PS: I haven't tested therefore needs verification of whether this is sufficient or not.

@krabina
Copy link
Contributor

krabina commented Mar 24, 2023

I think this is solved with the new datatables format. #771

@krabina krabina closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants