You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Initial position on the question of refactored formats:
Refactored formats should go into /src as what happened in #314. This is to get some uniformity and have somewhat of a task list about the once that are tested and those that contain "old" code. There is no rush to make the switch and only the once that are truly refactored should be moved to/src.
One of my biggest problems when looking for something in the SMW code is that I never know, in which folder to start. Given the structural changes in SMW the "clean slate" approach makes sense, but I think SRF is already structured well enough and any new folder structure will look pretty much the same as the old one.
I would also challenge the other two points. Arranging the project structure to have a tasklist is somewhat similar to putting ToDos and FixMes in the code. If we want a task list we should use a Github issue/project/whatever.
And test coverage or 'refactoring done' as a criterion to move formats to the new folder will probably not work either. I am working on the Filtered format right now. Done some refactoring, but it is still messy. Move over or not? Same goes probably for a number of other formats.
Finally with SRF we are in a situation, where usually a format is worked on when somebody has an issue with it. Given this approach we will end up having the src and formats folders side by side forever because some zombie formats will never get cleaned up.
So, I would suggest
Tasks
Moving all formats to src (or what about src/Formats?)
Creating a Rework project on Github
If possible removing the unused, unmaintained formats
The text was updated successfully, but these errors were encountered:
Issue
Initial position on the question of refactored formats:
@s7eph4n responded with:
So, I would suggest
Tasks
src
(or what aboutsrc/Formats
?)The text was updated successfully, but these errors were encountered: