bugfix (value filter does not filter out all empty values) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional content parsing is influenced by special page/template status. An eyeball check on the following options (format=tagcloud): 1 link=all 2 link=none 3 template=TagCloud / link=none 4 template=TagCloud / link=all 5 widget=wordcloud / link=none 6 widget=wordcloud / link=all 7 widget=wordcloud / template=TagCloud 8 widget=sphere / link=none 9 widget=sphere / link=all 10 widget=sphere / template=TagCloud
Added a case for empty values
|
I'm guessing it does what it says as we don't run any qunit tests here. |
mwjames
added a commit
that referenced
this pull request
Mar 1, 2014
bugfix (value filter does not filter out all empty values)
| for ( var j = 0; j < printoutValues.length && ! selectedFoundInPrintout; ++j ) { | ||
| selectedFoundInPrintout = selectedFoundInPrintout || ( printoutValues[j] == targetValues[k] ); | ||
| } | ||
|
|
There was a problem hiding this comment.
such indenting. many complexly. much wow omg
There was a problem hiding this comment.
Quite true. Truth be told, the whole format could well use a rewrite.
|
@s7eph4n Can you please add a line about this in the release notes (for 1.9.1)? |
|
Sorry for not responding. Was on vacation without internet access. |
|
I already updated the stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a case for empty values