fixed bug with mainlabel causing duplicate headers in excel format. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if mainlabel parameter was set to "Test", the first two columns in the excel file would result in column headers like the following: Test Test# This patch filters out the second column header Test#
| @@ -195,6 +198,10 @@ protected function populateDocumentWithHeaders ( $res, $sheet ) { | |||
| $colOffset = 0; | |||
| foreach ( $res->getPrintRequests() as $pr ) { | |||
| $header = $pr->getLabel(); | |||
| if($this->skipExtraMainLabel($header) ){ | |||
There was a problem hiding this comment.
how about flipping the return value of this method and renaming it to shouldShowHeader(), and then bringing the stuff inside the body of this foreach into the body of the if, and getting rid of the odd continue statement?
|
any ETA on merge? |
JeroenDeDauw
added a commit
that referenced
this pull request
Mar 10, 2014
fixed bug with mainlabel causing duplicate headers in excel format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if mainlabel parameter was set to "Test", the first two columns in the excel
file would result in column headers like the following:
Test Test#
This patch filters out the second column header Test#
Note, this is also the result seen in the CSV format...