Fix initialization of srfgScriptPath #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought of that exact fix, and tried it, but it didn't work for me on my wiki. But maybe I just made a mistake - if you tried it and it worked for you, then it sounds good. |
|
I confirmed it works on a setup where the stuff is installed into MW via Composer. That does not cover ExtensionInstaller based installs and tarball builds. Not sure why this would not fix these though. |
|
I was using Composer, so I probably just made an error. |
|
Will merge this soon if no one objects. The main use case went from broken to non-broken after all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14