Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math format to use getLocalizedFormattedNumber, refs 248 #250

Merged
merged 1 commit into from
Jul 8, 2017
Merged

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Jul 1, 2017

This PR is made in reference to: #248

This PR addresses or contains:

  • Use NumberValue::getLocalizedFormattedNumber to get the localized format according to settings available
  • Cannot be back-ported to SRF 2.5.x (as that would allow SMW 2.1) [0] because the change requires at least SMW 2.4.x

[0] https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/2.5.x/composer.json#L50

This PR includes:

  • Update of RELEASE-NOTES.md
  • Tests (unit/integration)
  • CI build passed

@mwjames
Copy link
Contributor Author

mwjames commented Jul 1, 2017

It currently fails and requires SMW 2.5.3 where related messages for pt-br were updated in order for the integration test to pass.

@kghbln
Copy link
Member

kghbln commented Jul 1, 2017

@mwjames So this could be backported to 2.x. Will do SRF 2.5.1 the same day as SMW 2.5.3 if that's ok.

@kghbln
Copy link
Member

kghbln commented Jul 1, 2017

Cannot be back-ported to SRF 2.5.x (as that would allow SMW 2.1) [0] because the change requires at least SMW 2.4.x

@mwjames Never mind my previous post.

@kghbln kghbln added this to the 3.0.0 milestone Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants