Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for instanceof Title #27

Merged
merged 1 commit into from
Mar 29, 2014
Merged

Check for instanceof Title #27

merged 1 commit into from
Mar 29, 2014

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Mar 28, 2014

Mail from Cicalese, Cindy:

Tested on MediaWiki 1.21 and 1.22 throws PHP Fatal error: Call to a member function isSpecialPage() on a non-object in …/mediawiki/extensions/SemanticResultFormats/formats/tagcloud/TagCloud.php on line 80

I get this error if I include any tagcloud in my wiki. An example is the following:

{{#ask:[[Tags::+]]
|?Tags
|format=tagcloud
|template=TagTagCloud
|maxtags=75
|limit=10000
}}

@mwjames
Copy link
Contributor Author

mwjames commented Mar 28, 2014

Caused by the RequestContext returning a null instead of a Title object.

@mwjames mwjames added this to the 1.9.0.2 milestone Mar 28, 2014
@mwjames mwjames added the bug label Mar 28, 2014
@cicalese
Copy link
Contributor

Thank you! I have confirmed that this fix corrects the error.

JeroenDeDauw added a commit that referenced this pull request Mar 29, 2014
@JeroenDeDauw JeroenDeDauw merged commit 0b65e7c into master Mar 29, 2014
@JeroenDeDauw JeroenDeDauw deleted the tagcloud-null-title branch March 29, 2014 03:18
@formwandler
Copy link

I can also confirm that this fixed my update problems on PHP 5.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants