Check for instanceof Title #27

Merged
merged 1 commit into from Mar 29, 2014

Conversation

Projects
None yet
4 participants
@mwjames
Contributor

mwjames commented Mar 28, 2014

Mail from Cicalese, Cindy:

Tested on MediaWiki 1.21 and 1.22 throws PHP Fatal error: Call to a member function isSpecialPage() on a non-object in …/mediawiki/extensions/SemanticResultFormats/formats/tagcloud/TagCloud.php on line 80

I get this error if I include any tagcloud in my wiki. An example is the following:

{{#ask:[[Tags::+]]
|?Tags
|format=tagcloud
|template=TagTagCloud
|maxtags=75
|limit=10000
}}
@mwjames

This comment has been minimized.

Show comment Hide comment
@mwjames

mwjames Mar 28, 2014

Contributor

Caused by the RequestContext returning a null instead of a Title object.

Contributor

mwjames commented Mar 28, 2014

Caused by the RequestContext returning a null instead of a Title object.

@mwjames mwjames added this to the 1.9.0.2 milestone Mar 28, 2014

@mwjames mwjames added the bug label Mar 28, 2014

@cicalese

This comment has been minimized.

Show comment Hide comment
@cicalese

cicalese Mar 28, 2014

Contributor

Thank you! I have confirmed that this fix corrects the error.

Contributor

cicalese commented Mar 28, 2014

Thank you! I have confirmed that this fix corrects the error.

JeroenDeDauw added a commit that referenced this pull request Mar 29, 2014

@JeroenDeDauw JeroenDeDauw merged commit 0b65e7c into master Mar 29, 2014

1 check passed

default Scrutinizer: 2 updated code elements — Travis: Passed
Details

@JeroenDeDauw JeroenDeDauw deleted the tagcloud-null-title branch Mar 29, 2014

@formwandler

This comment has been minimized.

Show comment Hide comment
@formwandler

formwandler Apr 22, 2014

I can also confirm that this fixed my update problems on PHP 5.3.3.

I can also confirm that this fixed my update problems on PHP 5.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment