Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline, fix subobject issues, refs 294 #295

Merged
merged 1 commit into from
Aug 26, 2017
Merged

Timeline, fix subobject issues, refs 294 #295

merged 1 commit into from
Aug 26, 2017

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Aug 26, 2017

This PR is made in reference to: #294

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes: #294

@mwjames
Copy link
Contributor Author

mwjames commented Aug 26, 2017

The code has already a note " ... this code is just insane; rewrite from 0 is probably the only way to get it right", and yes it took me a while to not introduce additional madness but seriously the code does not lend itself to be crowned as maintainable.

@mwjames mwjames merged commit d22effe into master Aug 26, 2017
@mwjames mwjames deleted the timeline-sobj branch August 26, 2017 17:27
@mwjames
Copy link
Contributor Author

mwjames commented Aug 26, 2017

This PR also fixes an issue on displaying the preferred DISPLAYTITlLE and while not related, selecting a time band in Special:Ask has been fixed by SemanticMediaWiki/SemanticMediaWiki#2652.

kghbln pushed a commit that referenced this pull request Sep 16, 2017
@kghbln kghbln added this to the 2.5.3 milestone Sep 16, 2017
@kghbln
Copy link
Member

kghbln commented Sep 16, 2017

Back-ported to the 2.5.x branch with 1ed273a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants