Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to JitGraph SRF format for release #3

Closed
wants to merge 1 commit into from

Conversation

rabanks
Copy link

@rabanks rabanks commented Dec 2, 2013

Initial version of JitGraph changes for review

@JeroenDeDauw
Copy link
Member

@rabanks Thanks for the patch, and sorry this just sat here. I noticed due to the link on the mailing list.

I had a quick look at this now and did not see anything crazy. Can't do a truly thorough review unfortunately.

To get this merged, the following needs to happen:

  • Verify the code still works as expected with SRF master and SMW master.
  • Update the release notes to reflect the changes relevant to the users (if any) (in particular things such as removed parameters, no longer accepted values, new options, etc)
  • Get verification that things did not break from a second source, such as a user of the format that tries out the new code. (Or a thorough review of a dev)

@mwjames
Copy link
Contributor

mwjames commented Nov 4, 2017

This PR has been since Dec 2, 2013, and I can hardly see any progress. Please open a new PR against the current master, if this is still being pursued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants