Correctly format whole-hour timezones west of UTC #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull! @JeroenDeDauw It will be great if you could have a peep at this. |
|
@JeroenDeDauw Re-ping. |
|
Looking at this makes me a bit sad. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change seems OK to me, but I wasn't able to run the unit tests locally and it isn't clear from the Travis output what might be wrong.
I'd love some guidance on this, otherwise feel free to close this PR.
(the next step would be to add a test with the
America/St_Johnstimezone, as I suspect there is anabsneeded there as well, but I wanted to make one change at a time)