Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery: Remove feature switch, always use TraditionalImageGallery #444

Merged
merged 1 commit into from Oct 18, 2018

Conversation

s7eph4n
Copy link
Contributor

@s7eph4n s7eph4n commented Oct 13, 2018

  • Remove feature switch, always use TraditionalImageGallery now
  • Fix a potential 'method not found' warning
  • Fix inline documentation

This PR includes:

  • Update of RELEASE-NOTES.md
  • Tests (unit/integration)
  • CI build passed

Fixes #229

Also fix a potential 'method not found' warning and give some love to documentation

Fixes #229
@kghbln kghbln added this to the 3.0.1 milestone Oct 13, 2018
@kghbln
Copy link
Member

kghbln commented Oct 13, 2018

Also to be back-ported to 3.0.x branch.

@JeroenDeDauw JeroenDeDauw merged commit 981814d into master Oct 18, 2018
@JeroenDeDauw JeroenDeDauw deleted the gallery branch October 18, 2018 23:07
kghbln pushed a commit that referenced this pull request Feb 22, 2019
)

Also fix a potential 'method not found' warning and give some love to documentation

Fixes #229
@kghbln
Copy link
Member

kghbln commented Feb 22, 2019

Back-ported with 9a70155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants