Update SRF 'format=graph' to use GraphViz extension version 1.1+. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update SRF composer.json to suggest mediawiki/graphviz.
| $result = renderGraphviz( $graphInput ); | ||
| // Calls graphvizParserHook function from MediaWiki GraphViz extension | ||
| global $wgParser; | ||
| $result = GraphViz::graphvizParserHook( $graphInput, "", $wgParser ); |
There was a problem hiding this comment.
Use $GLOBALS['wgParser'] instead since we don't want to expose global $wgParser; to other objects
There was a problem hiding this comment.
to other objects
??? The only difference is in the function scope.
I prefer using $GLOBALS, though in this case it is the last of our worries, and global $wg is used all over the place anyway. So I'd not block this commit on that
mwjames
added a commit
that referenced
this pull request
Jun 25, 2014
Update SRF 'format=graph' to use GraphViz extension version 1.1+.
|
Release notes should be updated to state that format=graph is supported by PS : https://www.mediawiki.org/wiki/Extension:GraphViz still shows some |
|
Thanks for making |
|
@kghbln FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update SRF composer.json to suggest mediawiki/graphviz.