Fix bug in MapView format #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s7eph4n
reviewed
Jul 29, 2019
| @@ -78,11 +77,6 @@ public function getJsDataForRow( ResultItem $row ) { | |||
| } | |||
| } | |||
|
|
|||
| } else { | |||
| $this->getQueryPrinter()->addError( | |||
| Message::newFromKey( 'srf-filtered-map-geocoordinateparser-missing-error' )->inContentLanguage( | |||
There was a problem hiding this comment.
I think this is the only place where this message is used, so it can be removed from the i18n files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was still using the old class name which got removed some time ago. Hence this code was broken on modern PHP versions.
Removed the check altogether in second commit since there is no need for it.