Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidezeroes parameter to jqplotseries #565

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Add hidezeroes parameter to jqplotseries #565

merged 2 commits into from
Jan 27, 2020

Conversation

JeroenDeDauw
Copy link
Member

@JeroenDeDauw JeroenDeDauw commented Jan 16, 2020

Fixes #558

Untested. Needs at least a manual test before merge.

@JeroenDeDauw
Copy link
Member Author

@darenwelsh could you do a manual test?

@darenwelsh
Copy link
Member

Thanks! Yes, I will test this. It will be a few days before I get to it.

@darenwelsh
Copy link
Member

It looks like you added a parameter "hidezeroes". Is this configured in-wiki, as a parameter in the ask query? Or is this a parameter configured per-wiki in LocalSettings.php?

@kghbln
Copy link
Member

kghbln commented Jan 27, 2020

Looks very much like a parameter to the result format which you can use when specifying the result output of the respective inline query like e.g. charttitle, charttext, etc.

@darenwelsh
Copy link
Member

I added |hidezeroes=true to the ask query and it worked (it hid the zeroes). I removed that parameter and the zeroes show up (by default). So I think it works :)

image

@kghbln
Copy link
Member

kghbln commented Jan 27, 2020

I added |hidezeroes=true to the ask query and it worked (it hid the zeroes). I removed that parameter and the zeroes show up (by default). So I think it works :)

Great. Thanks for the successful test. :) Will merge this now.

@kghbln kghbln merged commit bb055b0 into master Jan 27, 2020
@kghbln kghbln deleted the hidezeroes branch January 27, 2020 20:21
@JeroenDeDauw
Copy link
Member Author

In release notes with 98fcb73

@JeroenDeDauw
Copy link
Member Author

@darenwelsh you could do a thank you tweet mentioning @ProWikiExperts since you already have an image you can stuff in there. (Sorry, full advertising mode Jeroen here :))

@darenwelsh
Copy link
Member

Will you be joining us at EMWCon in April? I'll buy you a beer!

@JeroenDeDauw
Copy link
Member Author

I hope to be at the next EU conference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jqplotseries format: Hide zero value labels in bar plot
3 participants