Fix tagcloud rendering behaviour on special and wikipages #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Don't forget to update the rel notes and bump the version nr to 1.9.0.1 alpha (or just 1.9.0.1 is you want to rel it right away) |
|
Tagged with 1.9.0.1 |
Additional content parsing is influenced by special page/template status. An eyeball check on the following options (format=tagcloud): 1 link=all 2 link=none 3 template=TagCloud / link=none 4 template=TagCloud / link=all 5 widget=wordcloud / link=none 6 widget=wordcloud / link=all 7 widget=wordcloud / template=TagCloud 8 widget=sphere / link=none 9 widget=sphere / link=all 10 widget=sphere / template=TagCloud
|
Ugh. We should be careful with amending and doing force pushes if we do not want to denial of service our TravisCI capacity: https://travis-ci.org/SemanticMediaWiki/SemanticResultFormats/builds I did the same for SMW earlier today. |
JeroenDeDauw
added a commit
that referenced
this pull request
Jan 16, 2014
Fix tagcloud rendering behaviour on special and wikipages
|
You forgot to bump the version number as defined in the entry point file. Now the 1.9.0.1 tag shows up as 1.9 on Special:Version. Lets be a bit more careful next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional content parsing is influenced by special page/template status.
An eyeball check on the following options (format=tagcloud):
1 link=all
2 link=none
3 template=TagCloud / link=none
4 template=TagCloud / link=all
5 widget=wordcloud / link=none
6 widget=wordcloud / link=all
7 widget=wordcloud / template=TagCloud
8 widget=sphere / link=none
9 widget=sphere / link=all
10 widget=sphere / template=TagCloud