Fixed issue #73 #74
Fixed issue #73 #74
Conversation
| * Implements esaping of special characters for iCalendar properties of type TEXT. This is defined | ||
| * in RFC2445 Section 4.3.11. | ||
| */ | ||
| static private function escapeICalendarText( $text ) { |
There was a problem hiding this comment.
Sure; escaping methods usually are static or global (imagine you would need to create an object to call htmlentities() in PHP). Escaping should not depend on an object instance.
There was a problem hiding this comment.
I'm not going to split hairs here since we have other areas that needs more attention but the static usage would only make sense if used as public where as private it is bound to the object instance.
There was a problem hiding this comment.
True. The only point of "static" here is to declare that the method does not depend on object state. A non-static method is a bit like a method that declares a global variable: I would rather avoid it if I don't have a specific use for this additional access. Since "static" (as opposed to global variables) modifies the API, a conceivable future use would also justify non-static methods (you don't want to make a public method non-static later when you change the implementation slightly).
I agree that "public" would be appropriate here too; luckily we probably won't need icalendar escaping anywhere else ;-)
|
Generally looks good |
|
By the way, if you want to see it in action, here is a page using it already (with a lot of stuff to escape in the icalendar output): |
Escape text type properties in icalendar as recommended in the RFC. Tested on Thunderbird's Lightning calendar plugin: this plugin correctly unescapes the content. Should work for other calendar tools as well.