Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight search results in new datatables format #776

Closed
wants to merge 1 commit into from

Conversation

Seb35
Copy link
Contributor

@Seb35 Seb35 commented May 22, 2023

This improves the recent work on the datatables format, it highlights the search results by using the library mark.js and its datatables plugin, both under MIT license.

See this blog post in datatables.net for an overview of this library mark.js and its integration.

This uses the library mark.js and its datatables plugin, both
under MIT license.
@thomas-topway-it
Copy link
Contributor

it would be good to manage it through a parameter, for instance

		$params['datatables-mark'] = [
			'type' => 'boolean',
			'message' => 'srf-paramdesc-datatables-library-option',
			'default' => false,
		];

and

		$params['datatables-mark.diacritics'] = [
			'type' => 'boolean',
			'message' => 'srf-paramdesc-datatables-library-option',
			'default' => false,
		];

etc. for the most relevant options available here https://markjs.io/#mark
so we keep the current design

@thomas-topway-it
Copy link
Contributor

hello @Seb35 can you resync the fork so we can merge it ?
thank you

@thomas-topway-it thomas-topway-it mentioned this pull request Dec 2, 2023
@jaideraf
Copy link
Member

Since #801 was merged, this PR should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants