preferred label and eventcalendar

[thomas-topway-it]

fixes #764

***attention! the proposed solution is a workaround for the use with SRF's ext.srf.api.query.js -> toList (a regex to match the printout label and custom label), however a preferred solution would be at SMW level trying to fix PrintRequest's Serializer -> doSerializeProp

[JeroenDeDauw]

Better to use types in PHP and remove the doc block

[JeroenDeDauw]

Tho you could keep the doc block and add more detailed type info such as PrintRequest[] or whatever the class name actually is.

[thomas-topway-it]

I've added the param type
* @param PrintRequest[] $printRequests

[JeroenDeDauw]

Without it being imported, this references to SRF\PrintRequest, which does not exist.

You need to make sure the type is actually correct. Otherwise it does not help by providing autocompletion and error detection in the IDE. PhpStorm can autocomplete on the type in the comment and even import it automatically for you.

[thomas-topway-it]

so it should rather be @param SMW\Query\PrintRequest[] $printRequests ?

[JeroenDeDauw]

That would resolve to SRF\SMW\Query\PrintRequest[]. You need a backslash at the front: \SMW\Query\PrintRequest[]

Though better is to import the name with an import statement, so you do not have the FQN in the docs.

[thomas-topway-it]

I've fixed it. Is it preferred with "use" also if the class object is not directly called ? (in this case is rather returned by $queryResult->getPrintRequests() )

[JeroenDeDauw]

Yes. Import statements are cleaner

[thomas-topway-it]

I have added the import statement

[krabina]

Thank you for reviewing, @JeroenDeDauw !